Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SuspendFunSwallowedCancellation rule #5666

Merged
merged 9 commits into from Apr 5, 2023
Merged

Add SuspendFunSwallowedCancellation rule #5666

merged 9 commits into from Apr 5, 2023

Commits on Feb 24, 2023

  1. Add SuspendFunInsideRunCatching rule

    @atulgpt
    atulgpt committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    ad461a0 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Add suggestion from code review

Co-authored-by: Róbert Papp <papp.robert.s@gmail.com>
    @atulgpt @TWiStErRob
    atulgpt and TWiStErRob committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    58608a8 View commit details
    Browse the repository at this point in the history

  3. Simplify logic to have single traversal 

    Rename rule to SuspendFunSwallowedCancellation
Add new TCs
    @atulgpt
    atulgpt committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    bcc0062 View commit details
    Browse the repository at this point in the history

  4. Address PR review comments 

    Check shouldPropagate inside while checking for loop
Simplify if else block
    @atulgpt
    atulgpt committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    4a961b0 View commit details
    Browse the repository at this point in the history

  5. Fix PR comments 

    Make the local function
Early return of the declaration of the variable
    @atulgpt
    atulgpt committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    76c320e View commit details
    Browse the repository at this point in the history

  6. Fix inconsistent class name and issue id

    @atulgpt
    atulgpt committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    1adaa73 View commit details
    Browse the repository at this point in the history

  7. Handle suspend operators 

    Report violating runCatching block instead of suspend call
Assert location in tests
    @atulgpt
    atulgpt committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    8405a19 View commit details
    Browse the repository at this point in the history

  8. Add two TC around operators 

    Add TCs for suspend fun noinline and crossinline lambda
    @atulgpt
    atulgpt committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    1217a4d View commit details
    Browse the repository at this point in the history

  9. Fix detekt error and fix test error

    @atulgpt
    atulgpt committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    d7e1309 View commit details
    Browse the repository at this point in the history