New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check Thread.sleep for block expression #5699
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏👏👏 Good one! 👏👏👏 Thanks :)
@atulgpt could you check CI? It seems that the snippets doesn't compile. Once that's fixed this is ready to merge. |
Add check of canGoInside when lambda argument is suspend
Hi @BraisGabin, updated the PR(also reworked the traversal logic as in the previous logic some newly added TCs were failing) @cortinico at the comment #5666 (comment) I told about there are some bugs in coroutine related rule(some not honoring |
Codecov Report
@@ Coverage Diff @@
## main #5699 +/- ##
============================================
- Coverage 84.59% 84.57% -0.03%
+ Complexity 3790 3786 -4
============================================
Files 546 546
Lines 12918 12937 +19
Branches 2268 2273 +5
============================================
+ Hits 10928 10941 +13
- Misses 861 863 +2
- Partials 1129 1133 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Add more TCs around which failed in previous implementation
Hi @BraisGabin , some intermittent error in CI can you retrigger? |
Fixes #5659
Add check of canGoInside when lambda argument is suspend