Stop configuring report merge tasks while configuring Detekt tasks #5813
+25
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5813 +/- ##
=========================================
Coverage 84.61% 84.61%
Complexity 3787 3787
=========================================
Files 546 546
Lines 12918 12918
Branches 2268 2268
=========================================
Hits 10930 10930
Misses 862 862
Partials 1126 1126 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
TWiStErRob
reviewed
Feb 22, 2023
TWiStErRob
reviewed
Feb 22, 2023
TWiStErRob
approved these changes
Feb 22, 2023
TWiStErRob
reviewed
Feb 22, 2023
TWiStErRob
reviewed
Feb 22, 2023
See point 2: https://docs.gradle.org/8.0.1/userguide/task_configuration_avoidance.html#sec:task_configuration_avoidance_general > Only mutate the current task inside a configuration action... Mutating > anything other than the current task can cause indeterminate behavior in > your build.
chao2zhang
approved these changes
Feb 22, 2023
3flex
force-pushed
the
simplify-merging
branch
from
4f1cd71 to
ece4374
Compare
|
It was caught after #5772 was merged - I don't think it's related to Gradle 8. That warning from the Gradle docs that I referenced has been there for some time, I just haven't had a closer look until I made the change in #5772, not realising that the tasks had to be eagerly configured with the current way of configuring report merging. |
BraisGabin
approved these changes
Feb 23, 2023
TWiStErRob
approved these changes
Feb 23, 2023
TWiStErRob
added a commit
to TWiStErRob/net.twisterrob.colorfilters
that referenced
this pull request
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See point 2: https://docs.gradle.org/8.0.1/userguide/task_configuration_avoidance.html#sec:task_configuration_avoidance_general
Also see: #5772 (comment).
Docs should be updated to align - that can be done in a new commit once these changes are reviewed & approved.