Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude super call when generating guard clauses #5835

Merged
merged 1 commit into from
Feb 26, 2023

Conversation

atulgpt
Copy link
Contributor

@atulgpt atulgpt commented Feb 25, 2023

Fixes #5680

@codecov
Copy link

codecov bot commented Feb 25, 2023

Codecov Report

Merging #5835 (0e50d27) into main (2e703f0) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff            @@
##               main    #5835   +/-   ##
=========================================
  Coverage     84.59%   84.59%           
  Complexity     3776     3776           
=========================================
  Files           546      546           
  Lines         12916    12917    +1     
  Branches       2268     2269    +1     
=========================================
+ Hits          10926    10927    +1     
  Misses          861      861           
  Partials       1129     1129           
Impacted Files Coverage Δ
.../io/gitlab/arturbosch/detekt/rules/GuardClauses.kt 13.33% <50.00%> (+6.19%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cortinico
Copy link
Member

Great stuff 👍

@cortinico cortinico added this to the 1.23.0 milestone Feb 26, 2023
@schalkms schalkms merged commit 455096e into detekt:main Feb 26, 2023
@atulgpt atulgpt deleted the fixes-5680 branch February 26, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

excludeGuardClauses in ReturnCount should ignore first super call
3 participants