New Rule: `BracesOnWhenStatements` with configurable parameters #5838

VitalyVPinchuk · 2023-02-26T14:23:09Z

Similar to #5700

github-actions · 2023-02-26T14:23:46Z

	Messages
📖	Thanks for adding a new rule to detekt ❤️
✅	We detekted that you added tests, to your rule, that's awesome!
✅	We detekted that you updated the `default-detekt-config.yml` file, that's awesome!

Generated by 🚫 dangerJS against 70183de

codecov · 2023-02-26T14:47:38Z

Codecov Report

Merging #5838 (0e45543) into main (d067a13) will increase coverage by 0.09%.
The diff coverage is 93.18%.

❗ Current head 0e45543 differs from pull request most recent head 70183de. Consider uploading reports for the commit 70183de to get more accurate results

@@             Coverage Diff              @@
##               main    #5838      +/-   ##
============================================
+ Coverage     84.59%   84.68%   +0.09%     
- Complexity     3776     3859      +83     
============================================
  Files           546      550       +4     
  Lines         12916    13109     +193     
  Branches       2268     2313      +45     
============================================
+ Hits          10926    11102     +176     
- Misses          861      868       +7     
- Partials       1129     1139      +10

Impacted Files	Coverage Δ
...bosch/detekt/rules/style/BracesOnWhenStatements.kt	`93.02% <93.02%> (ø)`
...rturbosch/detekt/rules/style/StyleGuideProvider.kt	`100.00% <100.00%> (ø)`

... and 59 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

BraisGabin

The tests are so easy to read!! 😍. I left some comments but this PR looks really really good!

...ules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/BracesOnWhenStatements.kt

...-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/BracesOnWhenStatementsSpec.kt

TWiStErRob

Nice one, a few changes are needed to make sense of consistent/multi-statement. But the majority is good! Thank you!

detekt-core/src/main/resources/default-detekt-config.yml

...-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/BracesOnWhenStatementsSpec.kt

...ules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/BracesOnWhenStatements.kt

…/rules/style/BracesOnWhenStatements.kt Co-authored-by: Róbert Papp <papp.robert.s@gmail.com>

VitalyVPinchuk · 2023-03-09T15:28:53Z

Also, I can't engage this rule in detekt.yml as it fails regardless of any parameter.

BraisGabin · 2023-03-14T22:11:27Z

Also, I can't engage this rule in detekt.yml as it fails regardless of any parameter.

I don't understand the your statment. Can you elavorate?

VitalyVPinchuk · 2023-03-15T13:06:04Z

Also, I can't engage this rule in detekt.yml as it fails regardless of any parameter.

I don't understand the your statment. Can you elavorate?

I mean if I turn on this rule, detekt task fails. No matter what parameters I use in the rule: consistent, necessary, etc. We have to fix codebase a bit

BraisGabin · 2023-03-15T23:03:31Z

Oh, sure. No problem about that. We can enable it later in other pr with the proper fixes.

...ules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/BracesOnWhenStatements.kt

...-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/BracesOnWhenStatementsSpec.kt

...ules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/BracesOnWhenStatements.kt

...-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/BracesOnWhenStatementsSpec.kt

...ules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/BracesOnWhenStatements.kt

TWiStErRob

Sorry for the delay, move was longer than expected. This looks good now, just some final touches / simplifications. Happy to help finishing up, find me on Slack. Please look through all the unresolved conversations on the PR, there might be some hiding behind expanders.

...ules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/BracesOnWhenStatements.kt

...-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/BracesOnWhenStatementsSpec.kt

...ules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/BracesOnWhenStatements.kt

...-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/BracesOnWhenStatementsSpec.kt

...ules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/BracesOnWhenStatements.kt

TWiStErRob

One last round 🏆 .
Please have a look at all (potentially hidden) unresolved conversations.

...ules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/BracesOnWhenStatements.kt

…/rules/style/BracesOnWhenStatements.kt Co-authored-by: Róbert Papp <papp.robert.s@gmail.com>

VitalyVPinchuk added 3 commits February 25, 2023 18:03

Add "BracesOnWhenStatements" rule

e003b8a

Merge remote-tracking branch 'origin/main' into braces_when

c30b09d

Fix after merge

acd5baf

github-actions bot added the rules label Feb 26, 2023

VitalyVPinchuk changed the title ~~New Rule: BracesOnWhenStatements with configurable parameters~~ New Rule: BracesOnWhenStatements with configurable parameters Feb 26, 2023

vercel bot deployed to Preview February 26, 2023 14:28 View deployment

BraisGabin reviewed Feb 28, 2023

View reviewed changes

BraisGabin approved these changes Mar 3, 2023

View reviewed changes

cortinico added the notable changes label Mar 3, 2023

cortinico added this to the 1.23.0 milestone Mar 3, 2023

TWiStErRob requested changes Mar 7, 2023

View reviewed changes

Update detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt…

0429826

…/rules/style/BracesOnWhenStatements.kt Co-authored-by: Róbert Papp <papp.robert.s@gmail.com>

vercel bot had a problem deploying to Preview March 7, 2023 22:11 Failure

Update detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt…

c1a1f85

…/rules/style/BracesOnWhenStatements.kt Co-authored-by: Róbert Papp <papp.robert.s@gmail.com>

vercel bot had a problem deploying to Preview March 7, 2023 22:18 Failure

Update detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt…

003cfdb

…/rules/style/BracesOnWhenStatements.kt Co-authored-by: Róbert Papp <papp.robert.s@gmail.com>

vercel bot had a problem deploying to Preview March 7, 2023 22:23 Failure

Update detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt…

40647b8

…/rules/style/BracesOnWhenStatements.kt Co-authored-by: Róbert Papp <papp.robert.s@gmail.com>

vercel bot had a problem deploying to Preview March 7, 2023 22:38 Failure

VitalyVPinchuk force-pushed the braces_when branch from 2e41d56 to 5872284 Compare March 8, 2023 02:38

vercel bot deployed to Preview March 8, 2023 02:44 View deployment

VitalyVPinchuk force-pushed the braces_when branch from 5872284 to 3497d3d Compare March 8, 2023 20:53

vercel bot deployed to Preview March 8, 2023 20:58 View deployment

Fix tests and bugs

99ade13

VitalyVPinchuk force-pushed the braces_when branch from 3497d3d to 99ade13 Compare March 8, 2023 21:27

vercel bot deployed to Preview March 8, 2023 21:33 View deployment

TWiStErRob reviewed Mar 17, 2023

View reviewed changes

Fix tests and bugs

191644c

vercel bot deployed to Preview March 19, 2023 20:00 View deployment

VitalyVPinchuk requested a review from TWiStErRob March 26, 2023 16:08

TWiStErRob reviewed Apr 5, 2023

View reviewed changes

vercel bot deployed to Preview April 8, 2023 00:06 View deployment

VitalyVPinchuk requested a review from TWiStErRob April 8, 2023 12:46

Add various improvements

457c337

VitalyVPinchuk force-pushed the braces_when branch from bbc41bf to 457c337 Compare April 10, 2023 12:28

vercel bot deployed to Preview April 10, 2023 12:34 View deployment

TWiStErRob reviewed Apr 13, 2023

View reviewed changes

Add various improvements

0e45543

TWiStErRob reviewed Apr 13, 2023

View reviewed changes

...ules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/BracesOnWhenStatements.kt Outdated Show resolved Hide resolved

TWiStErRob approved these changes Apr 13, 2023

View reviewed changes

Update detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt…

70183de

…/rules/style/BracesOnWhenStatements.kt Co-authored-by: Róbert Papp <papp.robert.s@gmail.com>

vercel bot deployed to Preview April 13, 2023 15:13 View deployment

BraisGabin merged commit 70161db into detekt:main Apr 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Rule: `BracesOnWhenStatements` with configurable parameters #5838

New Rule: `BracesOnWhenStatements` with configurable parameters #5838

VitalyVPinchuk commented Feb 26, 2023

github-actions bot commented Feb 26, 2023 •

edited

Loading

codecov bot commented Feb 26, 2023 •

edited

Loading

BraisGabin left a comment •

edited

Loading

TWiStErRob left a comment

VitalyVPinchuk commented Mar 9, 2023

BraisGabin commented Mar 14, 2023

VitalyVPinchuk commented Mar 15, 2023

BraisGabin commented Mar 15, 2023

TWiStErRob left a comment •

edited

Loading

TWiStErRob left a comment •

edited

Loading

New Rule: BracesOnWhenStatements with configurable parameters #5838

New Rule: BracesOnWhenStatements with configurable parameters #5838

Conversation

VitalyVPinchuk commented Feb 26, 2023

github-actions bot commented Feb 26, 2023 • edited Loading

codecov bot commented Feb 26, 2023 • edited Loading

Codecov Report

BraisGabin left a comment • edited Loading

Choose a reason for hiding this comment

TWiStErRob left a comment

Choose a reason for hiding this comment

VitalyVPinchuk commented Mar 9, 2023

BraisGabin commented Mar 14, 2023

VitalyVPinchuk commented Mar 15, 2023

BraisGabin commented Mar 15, 2023

TWiStErRob left a comment • edited Loading

Choose a reason for hiding this comment

TWiStErRob left a comment • edited Loading

Choose a reason for hiding this comment

New Rule: `BracesOnWhenStatements` with configurable parameters #5838

New Rule: `BracesOnWhenStatements` with configurable parameters #5838

github-actions bot commented Feb 26, 2023 •

edited

Loading

codecov bot commented Feb 26, 2023 •

edited

Loading

BraisGabin left a comment •

edited

Loading

TWiStErRob left a comment •

edited

Loading

TWiStErRob left a comment •

edited

Loading