Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnnecessaryLet: fix false positive in call chains #6052

Merged
merged 2 commits into from
Apr 30, 2023

Conversation

t-kameyama
Copy link
Contributor

Fixes #5701

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #6052 (07b4287) into main (1b943d6) will increase coverage by 0.01%.
The diff coverage is 91.66%.

@@             Coverage Diff              @@
##               main    #6052      +/-   ##
============================================
+ Coverage     84.85%   84.87%   +0.01%     
- Complexity     3949     3954       +5     
============================================
  Files           561      561              
  Lines         13256    13253       -3     
  Branches       2315     2314       -1     
============================================
  Hits          11248    11248              
  Misses          868      868              
+ Partials       1140     1137       -3     
Impacted Files Coverage Δ
...ab/arturbosch/detekt/rules/style/UnnecessaryLet.kt 89.36% <91.66%> (+5.36%) ⬆️

@BraisGabin BraisGabin merged commit 3ed8e2c into detekt:main Apr 30, 2023
@t-kameyama t-kameyama deleted the issue_5701 branch April 30, 2023 09:56
@TWiStErRob
Copy link
Member

Thank you @t-kameyama! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnnecessaryLet false positive on let in the middle of the chain doing a cast
5 participants