CanBeNonNullable: Check parent condition for checking if nullability info is used or not #6064
+52
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #6064 +/- ##
============================================
- Coverage 84.86% 84.84% -0.02%
Complexity 3975 3975
============================================
Files 564 564
Lines 13300 13300
Branches 2325 2327 +2
============================================
- Hits 11287 11285 -2
Misses 870 870
- Partials 1143 1145 +2
|
cortinico
changed the title
marschwar
approved these changes
May 4, 2023
BraisGabin
approved these changes
May 5, 2023
| val code = """ | ||
| fun foo(a: Int?, other: Int) { | ||
| when { | ||
| a != null || other % 2 == 0 -> println(2 + other) |
There was a problem hiding this comment.
I always have doubts about this. Basically it is a boolean and makes the function do something if it is true. But probably that's probably work for another rule.
There was a problem hiding this comment.
Hi, @BraisGabin can you create an issue about the smell here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5799