UnusedPrivateProperty: Fix false postive by ignoring data classes #6151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atulgpt
changed the title
Codecov Report
@@ Coverage Diff @@
## main #6151 +/- ##
============================================
- Coverage 84.94% 84.94% -0.01%
Complexity 4026 4026
============================================
Files 569 569
Lines 13498 13501 +3
Branches 2381 2384 +3
============================================
+ Hits 11466 11468 +2
Misses 869 869
- Partials 1163 1164 +1
|
t-kameyama
reviewed
May 26, 2023
| @@ -108,7 +109,8 @@ private class UnusedPrivatePropertyVisitor(private val allowedNames: Regex) : De | |||
| constructor.valueParameters | |||
| .filter { | |||
| (it.isPrivate() || (!it.hasValOrVar() && !constructor.isActual())) && | |||
| it.containingClassOrObject?.isExpect() == false | |||
| it.containingClassOrObject?.isExpect() == false && | |||
| (constructor.parent as? KtClass)?.isData() != true | |||
There was a problem hiding this comment.
The same goes for value classes.
@JvmInline value class Foo(private val value: String)
inline class Bar(private val value: String)
schalkms
approved these changes
May 27, 2023
BraisGabin
approved these changes
May 27, 2023
cortinico
added
the
pick request
cortinico
pushed a commit
to cortinico/detekt
that referenced
this pull request
Jul 15, 2023
mgroth0
pushed a commit
to mgroth0/detekt
that referenced
this pull request
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6142