Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CanBeNonNullable: Fix false positive when property is defined after assignment #6210

Merged
merged 2 commits into from Jul 7, 2023

Conversation

t-kameyama
Copy link
Contributor

Fixes #6199

@codecov
Copy link

codecov bot commented Jun 11, 2023

Codecov Report

Merging #6210 (241fb90) into main (0ce4427) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #6210      +/-   ##
============================================
- Coverage     84.46%   84.46%   -0.01%     
  Complexity     3999     3999              
============================================
  Files           568      568              
  Lines         13439    13438       -1     
  Branches       2377     2376       -1     
============================================
- Hits          11351    11350       -1     
  Misses          934      934              
  Partials       1154     1154              
Impacted Files Coverage Δ
.../arturbosch/detekt/rules/style/CanBeNonNullable.kt 79.62% <100.00%> (+0.29%) ⬆️

... and 2 files with indirect coverage changes

@3flex 3flex merged commit 45ed694 into detekt:main Jul 7, 2023
23 checks passed
@3flex 3flex added this to the 2.0.0 milestone Jul 7, 2023
@t-kameyama t-kameyama deleted the issue_6199 branch July 7, 2023 04:04
@cortinico cortinico added the pick request Marker for PRs that should be ported to the 1.0 release branch label Jul 15, 2023
cortinico pushed a commit to cortinico/detekt that referenced this pull request Jul 15, 2023
…ssignment (detekt#6210)

* CanBeNonNullable: Fix false positive when property is defined after assignment

* Add tests
mgroth0 pushed a commit to mgroth0/detekt that referenced this pull request Feb 11, 2024
…ssignment (detekt#6210)

* CanBeNonNullable: Fix false positive when property is defined after assignment

* Add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pick request Marker for PRs that should be ported to the 1.0 release branch rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False Positive in CanBeNonNullable
5 participants