Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to SLF4J 2.x #6266

Merged
merged 1 commit into from Jul 8, 2023
Merged

Switch to SLF4J 2.x #6266

merged 1 commit into from Jul 8, 2023

Conversation

3flex
Copy link
Member

@3flex 3flex commented Jul 8, 2023

ktlint's dependencies have been updated, so detekt can now update to latest to align.

A tiny bit more information about why we've stayed on 1.x until now is here: #5238 (comment)

ktlint's dependencies have been updated, so detekt can now update to latest
to align.
@detekt-ci detekt-ci added the dependencies Pull requests that update a dependency file label Jul 8, 2023
@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Merging #6266 (3d71f82) into main (e740d85) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #6266      +/-   ##
============================================
- Coverage     84.45%   84.43%   -0.02%     
  Complexity     4005     4005              
============================================
  Files           568      568              
  Lines         13449    13448       -1     
  Branches       2379     2378       -1     
============================================
- Hits          11358    11355       -3     
- Misses          938      939       +1     
- Partials       1153     1154       +1     

see 2 files with indirect coverage changes

@schalkms schalkms added this to the 2.0.0 milestone Jul 8, 2023
@3flex 3flex merged commit 6fead25 into detekt:main Jul 8, 2023
23 checks passed
@3flex 3flex deleted the slf4j-2 branch July 9, 2023 21:33
@cortinico cortinico added the pick request Marker for PRs that should be ported to the 1.0 release branch label Jul 15, 2023
cortinico pushed a commit to cortinico/detekt that referenced this pull request Jul 15, 2023
ktlint's dependencies have been updated, so detekt can now update to latest
to align.
mgroth0 pushed a commit to mgroth0/detekt that referenced this pull request Feb 11, 2024
ktlint's dependencies have been updated, so detekt can now update to latest
to align.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file pick request Marker for PRs that should be ported to the 1.0 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants