Use pluginManagement to include builds #6268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be required to include detekt project in a composite build without errors. `includeBuild` in pluginManagement was de-incubated in Gradle 8.
Codecov Report
@@ Coverage Diff @@
## main #6268 +/- ##
=========================================
Coverage 85.20% 85.20%
Complexity 4035 4035
=========================================
Files 568 568
Lines 13448 13448
Branches 2378 2378
=========================================
Hits 11458 11458
Misses 831 831
Partials 1159 1159 |
Goooler
approved these changes
Jul 10, 2023
cortinico
approved these changes
Jul 14, 2023
Can we add a reference to this? |
If detekt was included in another build, yes. The PR fixes that. |
|
This was a lifesaver to test #6331 (comment), thanks! |
mgroth0
pushed a commit
to mgroth0/detekt
that referenced
this pull request
Feb 11, 2024
This seems to be required to include detekt project in a composite build without errors. `includeBuild` in pluginManagement was de-incubated in Gradle 8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be required to include detekt project in a composite build without errors.
includeBuildin pluginManagement was de-incubated in Gradle 8.