New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider deprecated rules as inactive when running allRules
#6381
Consider deprecated rules as inactive when running allRules
#6381
Conversation
Codecov Report
@@ Coverage Diff @@
## release/1.x #6381 +/- ##
==============================================
Coverage ? 84.93%
Complexity ? 4043
==============================================
Files ? 569
Lines ? 13545
Branches ? 2393
==============================================
Hits ? 11504
Misses ? 873
Partials ? 1168 |
🤔 I'm not sure here. But what will happen if you read the deprecation file? You should be able to extract that list too, right? This way you don't need to hardcode the list of deprecated rules. |
I totally agree. This could be the actual fix for the main branch. This was meant to be a quick fix only in case we want to deliver something quickly. But I guess that still could be done here. I will update the PR. |
Then this PR should go against 2.0, right? |
No, it is intended for the 1.x only. For the 2.x I would like to use #6382. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great for me 👍 Let's merge this so I can prepare .2
detekt-core/src/main/kotlin/io/gitlab/arturbosch/detekt/core/Analyzer.kt
Outdated
Show resolved
Hide resolved
Fix for 2.0 is #6413 |
We can merge this, right? |
Yup 👍 |
(quick) fixes #6336
Note: This PR targets the
release/1.x
branch instead ofmain
.Following this suggestion I hacked something up that should fix the issue short term. The idea is that all deprecated rules are considered as inactive in case detekt is run with the
allRules
option. We should probably find a better solution for the main branch.