Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnconditionalJumpStatementInLoop: don't report a conditional break in a single body expression #6443

Merged
merged 2 commits into from Aug 31, 2023
Merged

UnconditionalJumpStatementInLoop: don't report a conditional break in a single body expression #6443

merged 2 commits into from Aug 31, 2023

Conversation

t-kameyama
Copy link
Contributor

Fixes #6442

@BraisGabin BraisGabin enabled auto-merge (squash) August 31, 2023 07:38
@codecov
Copy link

codecov bot commented Aug 31, 2023 •
edited

Codecov Report

Patch coverage: 75.00% and no project coverage change.

Comparison is base (5672df8) 85.21% compared to head (729abfe) 85.21%.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #6443   +/-   ##
=========================================
  Coverage     85.21%   85.21%           
+ Complexity     4031     4028    -3     
=========================================
  Files           566      566           
  Lines         13175    13178    +3     
  Branches       2365     2366    +1     
=========================================
+ Hits          11227    11230    +3     
  Misses          774      774           
  Partials       1174     1174
Files Changed Coverage Δ
...ekt/rules/bugs/UnconditionalJumpStatementInLoop.kt 95.83% <75.00%> (+0.59%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BraisGabin BraisGabin merged commit d7935c3 into detekt:main Aug 31, 2023
22 of 23 checks passed
@detekt-ci
Copy link
Collaborator

Warnings
⚠️ This PR is approved with no milestone set. If merged, it won't appear in the detekt release notes.

Generated by 🚫 dangerJS against 729abfe

@simaotwx
Copy link

Thanks!

@BraisGabin BraisGabin added this to the 2.0.0 milestone Aug 31, 2023
@t-kameyama t-kameyama deleted the issue_6442 branch August 31, 2023 08:06
@cortinico cortinico added the pick request Marker for PRs that should be ported to the 1.0 release branch label Sep 1, 2023
cortinico pushed a commit that referenced this pull request Oct 30, 2023
@t-kameyama @BraisGabin @cortinico
UnconditionalJumpStatementInLoop: don't report a conditional break in…
eb52db7 
… a single body expression (#6443)

Co-authored-by: Brais Gabín <braisgabin@gmail.com>
mgroth0 pushed a commit to mgroth0/detekt that referenced this pull request Feb 11, 2024
@t-kameyama @BraisGabin @mgroth0
UnconditionalJumpStatementInLoop: don't report a conditional break in…
0c8b276 
… a single body expression (detekt#6443)

Co-authored-by: Brais Gabín <braisgabin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BraisGabin BraisGabin BraisGabin approved these changes

Assignees
No one assigned
Labels
pick request Marker for PRs that should be ported to the 1.0 release branch rules
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Specific code causes false positive of UnconditionalJumpStatementInLoop
5 participants
@t-kameyama @detekt-ci @simaotwx @BraisGabin @cortinico