Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false negative IgnoredReturnValue with scope functions #6446

Merged
merged 1 commit into from Sep 1, 2023

Conversation

t-kameyama
Copy link
Contributor

Fixes #6445

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 72.22% and project coverage change: -0.02% ⚠️

Comparison is base (cb050a1) 85.22% compared to head (d7a0dd5) 85.20%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6446      +/-   ##
============================================
- Coverage     85.22%   85.20%   -0.02%     
- Complexity     4044     4055      +11     
============================================
  Files           566      566              
  Lines         13223    13240      +17     
  Branches       2373     2382       +9     
============================================
+ Hits          11269    11281      +12     
  Misses          774      774              
- Partials       1180     1185       +5     
Files Changed Coverage Δ
...arturbosch/detekt/rules/bugs/IgnoredReturnValue.kt 84.50% <72.22%> (-4.39%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BraisGabin BraisGabin added this to the 2.0.0 milestone Sep 1, 2023
@cortinico cortinico added the pick request Marker for PRs that should be ported to the 1.0 release branch label Sep 1, 2023
@BraisGabin BraisGabin merged commit 39f0f6c into detekt:main Sep 1, 2023
22 of 23 checks passed
@t-kameyama t-kameyama deleted the issue_6445 branch September 1, 2023 13:34
mgroth0 pushed a commit to mgroth0/detekt that referenced this pull request Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pick request Marker for PRs that should be ported to the 1.0 release branch rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False negative IgnoredReturnValue with scope functions
4 participants