New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix false negative IgnoredReturnValue
with scope functions
#6446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #6446 +/- ##
============================================
- Coverage 85.22% 85.20% -0.02%
- Complexity 4044 4055 +11
============================================
Files 566 566
Lines 13223 13240 +17
Branches 2373 2382 +9
============================================
+ Hits 11269 11281 +12
Misses 774 774
- Partials 1180 1185 +5
☔ View full report in Codecov by Sentry. |
t-kameyama
force-pushed
the
issue_6445
branch
from
September 1, 2023 00:02
00c36c0
to
885db66
Compare
t-kameyama
force-pushed
the
issue_6445
branch
from
September 1, 2023 00:31
885db66
to
2e6dbf4
Compare
...ules-errorprone/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/IgnoredReturnValue.kt
Fixed
Show fixed
Hide fixed
t-kameyama
force-pushed
the
issue_6445
branch
from
September 1, 2023 00:45
2e6dbf4
to
7ed76da
Compare
...ules-errorprone/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/IgnoredReturnValue.kt
Fixed
Show fixed
Hide fixed
...ules-errorprone/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/IgnoredReturnValue.kt
Fixed
Show fixed
Hide fixed
t-kameyama
force-pushed
the
issue_6445
branch
from
September 1, 2023 00:53
7ed76da
to
d7a0dd5
Compare
BraisGabin
approved these changes
Sep 1, 2023
cortinico
added
the
pick request
Marker for PRs that should be ported to the 1.0 release branch
label
Sep 1, 2023
cortinico
approved these changes
Sep 1, 2023
cortinico
pushed a commit
that referenced
this pull request
Oct 30, 2023
mgroth0
pushed a commit
to mgroth0/detekt
that referenced
this pull request
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6445