ForbiddenMethodCall - Handle sequence of overridden methods #6478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BraisGabin
reviewed
Sep 12, 2023
| foundDescriptors.flatMap { | ||
| it.overriddenTreeUniqueAsSequence(true).toList() | ||
| } | ||
| }?.toSet() ?: return |
There was a problem hiding this comment.
We could avoid this call to toSet if we create sets directly instead of lists inside the let.
...les-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/ForbiddenMethodCallSpec.kt
Outdated
Show resolved
Hide resolved
BraisGabin
added
the
pick request
Co-authored-by: Brais Gabín <braisgabin@gmail.com>
BraisGabin
approved these changes
Sep 12, 2023
BraisGabin
approved these changes
Sep 12, 2023
cortinico
changed the title
cortinico
pushed a commit
that referenced
this pull request
Oct 30, 2023
* Handle sequence of overridden methods * Apply suggestions from code review Co-authored-by: Brais Gabín <braisgabin@gmail.com> * Create set inside let instead of using `toSet()` --------- Co-authored-by: Brais Gabín <braisgabin@gmail.com>
mgroth0
pushed a commit
to mgroth0/detekt
that referenced
this pull request
Feb 11, 2024
* Handle sequence of overridden methods * Apply suggestions from code review Co-authored-by: Brais Gabín <braisgabin@gmail.com> * Create set inside let instead of using `toSet()` --------- Co-authored-by: Brais Gabín <braisgabin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
overriddenTreeUniqueAsSequenceof overridden methods which gives all the methods even for the parent classesFixes #6474