Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inputstream leaking file descriptor in Gradle #6519

Merged
merged 1 commit into from Oct 1, 2023
Merged

Fix inputstream leaking file descriptor in Gradle #6519

merged 1 commit into from Oct 1, 2023

Conversation

pablobaxter
Copy link
Contributor

Fixes #6518

@detekt-ci
Copy link
Collaborator

Warnings
⚠️ It looks like this PR contains functional changes without a corresponding test.

Generated by 🚫 dangerJS against 77ad668

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7a9d960) 85.18% compared to head (77ad668) 85.18%.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #6519   +/-   ##
=========================================
  Coverage     85.18%   85.18%           
  Complexity     4037     4037           
=========================================
  Files           564      564           
  Lines         13273    13273           
  Branches       2387     2387           
=========================================
  Hits          11306    11306           
  Misses          773      773           
  Partials       1194     1194

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

schalkms
schalkms approved these changes Sep 30, 2023
View reviewed changes
Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for detekting and fixing this issue! 🙂

@schalkms schalkms added this to the 1.23.2 milestone Sep 30, 2023
@BraisGabin BraisGabin added the pick request Marker for PRs that should be ported to the 1.0 release branch label Oct 1, 2023
@BraisGabin BraisGabin merged commit 3b23142 into detekt:main Oct 1, 2023
23 checks passed
@joshfriend joshfriend mentioned this pull request Oct 3, 2023
Open
@Rodrigolmti
Copy link

Hello, do we have any estimation of when this fix will be released? Seems that it is impacting some projects out there.

@cortinico cortinico modified the milestones: 1.23.2, 2.0.0 Oct 22, 2023
cortinico pushed a commit that referenced this pull request Oct 30, 2023
@pablobaxter @cortinico
Fix inputstream leaking file descriptor in Gradle (#6519)
5cd9a28
mgroth0 pushed a commit to mgroth0/detekt that referenced this pull request Feb 11, 2024
@pablobaxter @mgroth0
Fix inputstream leaking file descriptor in Gradle (detekt#6519)
d1d5a3c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BraisGabin BraisGabin BraisGabin approved these changes

@schalkms schalkms schalkms approved these changes

Assignees
No one assigned
Labels
gradle-plugin pick request Marker for PRs that should be ported to the 1.0 release branch
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

File Descriptor Leak in DetektExtension.kt
6 participants
@pablobaxter @detekt-ci @Rodrigolmti @BraisGabin @schalkms @cortinico