fix(deps): update kotlin monorepo to v1.9.20 #6572

renovate · 2023-10-30T19:58:06Z

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
org.jetbrains.kotlin:kotlin-reflect (source)	`1.9.10` -> `1.9.20`
org.jetbrains.kotlin:kotlin-stdlib-jdk8 (source)	`1.9.10` -> `1.9.20`
org.jetbrains.kotlin:kotlin-main-kts (source)	`1.9.10` -> `1.9.20`
org.jetbrains.kotlin:kotlin-gradle-plugin-api (source)	`1.9.10` -> `1.9.20`
org.jetbrains.kotlin:kotlin-gradle-plugin (source)	`1.9.10` -> `1.9.20`
org.jetbrains.kotlin:kotlin-compiler-embeddable (source)	`1.9.10` -> `1.9.20`
org.jetbrains.kotlin:kotlin-compiler (source)	`1.9.10` -> `1.9.20`

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

3flex · 2023-11-01T01:35:34Z

Blocked on:

renovate · 2023-11-01T10:39:42Z

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

codecov · 2023-11-01T11:00:01Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9da42d0) 85.10% compared to head (80e8427) 85.11%.
Report is 1 commits behind head on main.

❗ Current head 80e8427 differs from pull request most recent head 6eb9280. Consider uploading reports for the commit 6eb9280 to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #6572      +/-   ##
============================================
+ Coverage     85.10%   85.11%   +0.01%     
+ Complexity     4083     4079       -4     
============================================
  Files           570      570              
  Lines         13376    13373       -3     
  Branches       2406     2405       -1     
============================================
- Hits          11384    11383       -1     
+ Misses          792      791       -1     
+ Partials       1200     1199       -1

Files	Coverage Δ
...h/detekt/rules/naming/InvalidPackageDeclaration.kt	`100.00% <ø> (+5.55%)`	⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

detekt-ci · 2023-11-01T11:13:15Z

	Warnings
⚠️	It looks like this PR contains functional changes without a corresponding test.

Generated by 🚫 dangerJS against 6eb9280

3flex · 2023-11-02T04:34:38Z

May be due to KT-60813. Further investigation required but the strack trace looks like it matches.

Strangely though the original issue was opened with 1.9.0, but it seems seeing it when updating 1.9.10 to 1.9.20. Target fix is 2.0.0-beta2 which won't be for a while. In the meantime we may need to disable formatting tests.

detekt-formatting/build.gradle.kts

This is due to detekt-main-kts embedding an old version of SLF4J which conflicts with the version used in detekt-formatting. This dependency isn't required for formatting tests as ktlint only requires the AST for its analysis and doesn't need to be compiled. See https://youtrack.jetbrains.com/issue/KT-60813

There are now changes other than version bump & checksum update which must be reviewed by others

3flex · 2023-11-08T07:31:18Z

@detekt/maintainers this builds now, can I please get a review on the workarounds & fixes? Thanks!

TWiStErRob · 2023-11-08T07:54:37Z

detekt-formatting/build.gradle.kts

@@ -12,7 +12,14 @@ dependencies {

    runtimeOnly(libs.slf4j.api)

-    testImplementation(projects.detektTest)
+    testImplementation(projects.detektTest) {
+        /* Workaround for https://youtrack.jetbrains.com/issue/KT-60813. Required due to detekt-main-kts embedding an


The issue is reported for 1.9.0, how come it just came out in 1.9.10-20 bump?

Oh, #6572 (comment)

Did you check/diff the 10 and 20 jar contents?

Not in any detail. I've spent a lot of time trying to ~~figure out what's going on~~ come up with the right workaround though so if you want to take over and try to find a better solution I'd be grateful - I'm just glad it's unblocked at this point.

Agreed, it seems an ok trade-off. I might have a look later if I find some time, but no point blocking.

#6636 for a potentially better solution (allows for running compiled tests)

I had a deeper look and found the differences.

Adding a previous version on the classpath didn't work, because the 1.9.10 and 1.9.20 versions have exactly the same Logger class in the jar, so the trigger must be something else.

I had a look at the dependency tree gradlew :d-f:dep --configuration=testRuntimeClasspath, and they look almost identical:

Full diff screenshot (long image)

However the actual runtime classpath: AutoCorrectLevelSpec::class.java.classLoader.ucp.path has significant differences, look for the order of the highlighted (blue) lines:

I cannot explain why the order changed so much, while the dependency tree didn't. My only hunch is that somewhere in Gradle there's a hash-ordered collection, and the hashed values so far always yielded a "good" order, with "1.9.20" string in the mix, this changed.

TWiStErRob · 2023-11-08T07:54:41Z

detekt-formatting/build.gradle.kts

+
+tasks.withType<Test>().configureEach {
+    // Required due to exclusion of kotlin-main-kts dependency above
+    systemProperty("compile-test-snippets", false)


Rather than disabling the compilation, how about adding the previous version of kotlin-main-kts to the classpath? Would that enable (keep) compilation ability in tests?

Tried but it didn't work, though I might have done something wrong

BraisGabin

As commented on the comments. This is clearly not ideal but I don't think that should block this PR.

* fix(deps): update kotlin monorepo to v1.9.20 * Update Kotlin compiler checksum * Fix 'Extension is shadowed by a member' warning * Exclude kotlin-main-kts from detekt-formatting testRuntimeClasspath This is due to detekt-main-kts embedding an old version of SLF4J which conflicts with the version used in detekt-formatting. This dependency isn't required for formatting tests as ktlint only requires the AST for its analysis and doesn't need to be compiled. See https://youtrack.jetbrains.com/issue/KT-60813 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Matthew Haughton <3flex@users.noreply.github.com>

renovate bot added the dependencies Pull requests that update a dependency file label Oct 30, 2023

vercel bot had a problem deploying to Preview October 30, 2023 19:59 Failure

renovate bot changed the title ~~fix(deps): update dependency org.jetbrains.kotlin:kotlin-compiler-embeddable to v1.9.20~~ fix(deps): update kotlin monorepo to v1.9.20 Oct 30, 2023

3flex mentioned this pull request Oct 31, 2023

chore(deps): update dependency org.jetbrains.kotlin.jvm to v1.9.20 #6573

Closed

1 task

3flex added pick request Marker for PRs that should be ported to the 1.0 release branch blocked labels Nov 1, 2023

3flex mentioned this pull request Nov 1, 2023

Remove redundant association of functional test compilation to main compilation #6592

Closed

renovate bot force-pushed the renovate/kotlin-monorepo branch from 9c058aa to 062ad62 Compare November 1, 2023 10:36

3flex removed the blocked label Nov 1, 2023

3flex previously approved these changes Nov 1, 2023

View reviewed changes

vercel bot deployed to Preview November 1, 2023 10:47 View deployment

detekt-ci added the rules label Nov 1, 2023

vercel bot deployed to Preview November 1, 2023 11:18 View deployment

3flex force-pushed the renovate/kotlin-monorepo branch from 5faa05d to 586435b Compare November 1, 2023 12:24

3flex added this to the 2.0.0 milestone Nov 1, 2023

vercel bot deployed to Preview November 1, 2023 12:38 View deployment

3flex added the blocked label Nov 2, 2023

detekt-ci added the build label Nov 3, 2023

github-advanced-security bot found potential problems Nov 3, 2023

View reviewed changes

detekt-formatting/build.gradle.kts Fixed Show fixed Hide fixed

vercel bot deployed to Preview November 3, 2023 03:46 View deployment

3flex force-pushed the renovate/kotlin-monorepo branch from ddf48ac to c9329e3 Compare November 3, 2023 03:51

vercel bot deployed to Preview November 3, 2023 03:57 View deployment

3flex removed the blocked label Nov 3, 2023

3flex force-pushed the renovate/kotlin-monorepo branch from c9329e3 to 80e8427 Compare November 3, 2023 03:59

vercel bot deployed to Preview November 3, 2023 04:10 View deployment

renovate bot and others added 4 commits November 8, 2023 18:12

fix(deps): update kotlin monorepo to v1.9.20

0690a55

Update Kotlin compiler checksum

d384d68

Fix 'Extension is shadowed by a member' warning

26b2789

3flex force-pushed the renovate/kotlin-monorepo branch from 80e8427 to 6eb9280 Compare November 8, 2023 07:13

vercel bot deployed to Preview November 8, 2023 07:21 View deployment

TWiStErRob reviewed Nov 8, 2023

View reviewed changes

BraisGabin approved these changes Nov 9, 2023

View reviewed changes

3flex merged commit 12bb998 into main Nov 9, 2023
21 checks passed

3flex deleted the renovate/kotlin-monorepo branch November 9, 2023 21:06

bpoland mentioned this pull request Nov 15, 2023

Point release for Kotlin 1.9.10 support #6428

Closed

3flex mentioned this pull request Nov 23, 2023

Fails to run with Kotlin 1.9.20 and Java 21 #6645

Closed

cortinico added the notable changes Marker for notable changes in the changelog label Nov 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(deps): update kotlin monorepo to v1.9.20 #6572

fix(deps): update kotlin monorepo to v1.9.20 #6572

renovate bot commented Oct 30, 2023 •

edited

3flex commented Nov 1, 2023 •

edited

renovate bot commented Nov 1, 2023

codecov bot commented Nov 1, 2023 •

edited

detekt-ci commented Nov 1, 2023 •

edited

3flex commented Nov 2, 2023

3flex commented Nov 8, 2023

TWiStErRob Nov 8, 2023

TWiStErRob Nov 8, 2023

TWiStErRob Nov 8, 2023

3flex Nov 8, 2023 •

edited

TWiStErRob Nov 8, 2023

TWiStErRob Nov 19, 2023 •

edited

TWiStErRob Nov 19, 2023

TWiStErRob Nov 8, 2023

3flex Nov 8, 2023 •

edited

BraisGabin left a comment

fix(deps): update kotlin monorepo to v1.9.20 #6572

fix(deps): update kotlin monorepo to v1.9.20 #6572

Conversation

renovate bot commented Oct 30, 2023 • edited

Configuration

3flex commented Nov 1, 2023 • edited

renovate bot commented Nov 1, 2023

Edited/Blocked Notification

codecov bot commented Nov 1, 2023 • edited

Codecov Report

detekt-ci commented Nov 1, 2023 • edited

3flex commented Nov 2, 2023

3flex commented Nov 8, 2023

TWiStErRob Nov 8, 2023

Choose a reason for hiding this comment

TWiStErRob Nov 8, 2023

Choose a reason for hiding this comment

TWiStErRob Nov 8, 2023

Choose a reason for hiding this comment

3flex Nov 8, 2023 • edited

Choose a reason for hiding this comment

TWiStErRob Nov 8, 2023

Choose a reason for hiding this comment

TWiStErRob Nov 19, 2023 • edited

Choose a reason for hiding this comment

TWiStErRob Nov 19, 2023

Choose a reason for hiding this comment

TWiStErRob Nov 8, 2023

Choose a reason for hiding this comment

3flex Nov 8, 2023 • edited

Choose a reason for hiding this comment

BraisGabin left a comment

Choose a reason for hiding this comment

renovate bot commented Oct 30, 2023 •

edited

3flex commented Nov 1, 2023 •

edited

codecov bot commented Nov 1, 2023 •

edited

detekt-ci commented Nov 1, 2023 •

edited

3flex Nov 8, 2023 •

edited

TWiStErRob Nov 19, 2023 •

edited

3flex Nov 8, 2023 •

edited