Add io.gitlab.arturbosch.detekt.generator.Main to the jar manifest #6613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6613 +/- ##
=========================================
Coverage 85.10% 85.10%
Complexity 4083 4083
=========================================
Files 570 570
Lines 13376 13376
Branches 2406 2406
=========================================
Hits 11384 11384
Misses 792 792
Partials 1200 1200 ☔ View full report in Codecov by Sentry. |
BraisGabin
added
the
pick request
chao2zhang
approved these changes
Nov 12, 2023
|
Do we need a new patch release 1.23.4? |
|
This is not critical so I don't think we need it for this. But with the Kotlin update we will need that point release. So I think that this fix should be added too |
cortinico
pushed a commit
that referenced
this pull request
Nov 25, 2023
mgroth0
pushed a commit
to mgroth0/detekt
that referenced
this pull request
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6600
We weren't adding declaring the Main class in the
detekt-generator-*-all.jar. This will fix that.