New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Kotlin 2.0 support (2.0.0-RC2) #6640
base: main
Are you sure you want to change the base?
Conversation
Hey @3flex after trying the commit 429a178 as you mentioned here #6715 (comment). I've been able to compile your branch and generate the library on my MavenLocal. But when I've run
Thanks :) |
You probably need to follow steps here: https://docs.gradle.org/8.3/release-notes.html#kotlin_k2 and be sure to use Gradle 8.3 or higher. Also have a read of https://kotlinlang.org/docs/whatsnew-eap.html#current-k2-compiler-limitations |
8652daa
to
68f3cc7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6640 +/- ##
============================================
- Coverage 84.70% 84.37% -0.34%
- Complexity 3992 4163 +171
============================================
Files 578 578
Lines 12163 12082 -81
Branches 2495 2478 -17
============================================
- Hits 10303 10194 -109
- Misses 626 644 +18
- Partials 1234 1244 +10 ☔ View full report in Codecov by Sentry. |
I wouldn't expect this to get merged to It also relies on a snapshot version of poko. I'm glad it's working well, and thank you for testing, but it's not ready to be merged. |
Thank you for telling me what I can expect. I appreciate your work on this and there is definitely no rush. I also understand your point about waiting for K2 to stabilizing more first. I will continue to test this in the meantime. |
Hey @3flex . I am eager to work with the changes from both this branch as well as If this sounds alright to you, I'd appreciate you advice on how to do this the best way with git. My current proposal is:
If I see any complicated merge conflicts, I would consult you. I expect to get this up to main incrementally, not all at once. I've never done something like this before so I want to check with you that it would work. In particular, I want to make sure the rebasing wouldn't be destructive (I have no idea how GitHub PRs handle rebasing) |
It really depends what the change is. This PR/branch is intended only to introduce support for Kotlin 2/K2 so any changes you want to make to this branch would need to support that goal. You'd said it's already working well, so I'm not sure what you'd want to change? Any other changes for detekt should be raised as separate PRs. I'll rebase this branch on I'm sorry but beyond that I can't provide much help, you can try stack overflow to ask questions about git usage. |
If I recall correctly, and I could have been mistaken, I think that this branch was about 6 months behind main but now it seems more caught up. Though, maybe I made a mistake. It's hard to tell with the rebasing.
That is basically my plan. The reason I said what I said before was to offer to help with the rebasing of this branch on top of main. I wasn't so much asking for help as much as I was asking if this would be a useful contribution, and I was asking for clarification on what style of git merging you preferred. |
Multiple labels are forbidden on statements from 2.0.0-Beta4 https://youtrack.jetbrains.com/issue/KT-53629
Unless I've missed something it seems that the classic method of running detekt is compatible with K2 but the compiler plugin isn't.
Testing & experimentation is encouraged.
Fixes #6715