Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix by checking the existence of label in previous statements #6671

Merged

Conversation

atulgpt
Copy link
Contributor

@atulgpt atulgpt commented Dec 1, 2023

Fixes #6657

@detekt-ci detekt-ci added the rules label Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3fc4d13) 84.83% compared to head (41a340b) 84.84%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6671   +/-   ##
=========================================
  Coverage     84.83%   84.84%           
- Complexity     4098     4103    +5     
=========================================
  Files           570      570           
  Lines         13179    13185    +6     
  Branches       2418     2420    +2     
=========================================
+ Hits          11181    11187    +6     
  Misses          789      789           
  Partials       1209     1209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BraisGabin BraisGabin added this to the 2.0.0 milestone Dec 2, 2023
@BraisGabin BraisGabin added the pick request Marker for PRs that should be ported to the 1.0 release branch label Dec 2, 2023
@BraisGabin BraisGabin merged commit 6496d2a into detekt:main Jan 3, 2024
23 checks passed
@atulgpt atulgpt deleted the fixes/6657/fix-uncondition-jump-false-pos branch January 6, 2024 13:41
mgroth0 pushed a commit to mgroth0/detekt that referenced this pull request Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pick request Marker for PRs that should be ported to the 1.0 release branch rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive for UnconditionalJumpStatementInLoop when nested loop does contain condition(s)
3 participants