Add ignoreAnnotatedFunctions to TooManyFunctions #6875
Merged
+77
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6875 +/- ##
=========================================
Coverage 84.12% 84.12%
+ Complexity 3932 3928 -4
=========================================
Files 577 577
Lines 13180 13180
Branches 2488 2489 +1
=========================================
Hits 11088 11088
Misses 851 851
Partials 1241 1241 ☔ View full report in Codecov by Sentry. |
cortinico
reviewed
Jan 16, 2024
...-complexity/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/complexity/TooManyFunctions.kt
Show resolved
Hide resolved
atulgpt
reviewed
Jan 16, 2024
...-complexity/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/complexity/TooManyFunctions.kt
Show resolved
Hide resolved
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...-complexity/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/complexity/TooManyFunctions.kt
Fixed
Show fixed
Hide fixed
This reverts commit 3d16e57.
BraisGabin
approved these changes
Jan 26, 2024
BraisGabin
added
the
pick request
cortinico
reviewed
Jan 27, 2024
| @@ -100,3 +100,15 @@ private fun FooLazyColumnPreview() { // Violation for FooLazyColumnPreview() | |||
| #### Recommended configuration | |||
|
|
|||
| * Set `ignoreAnnotated` to `['Preview']` | |||
| * | |||
cortinico
pushed a commit
that referenced
this pull request
Jan 31, 2024
* Add ignoreAnnotatedFunctions to TooManyFunctions * Add TooManyFunctions recommendation to compose docs * Ensure Preview annotation in tests is declared * Simplify hasAnnotation check * Revert "Simplify hasAnnotation check" This reverts commit 3d16e57.
cortinico
pushed a commit
that referenced
this pull request
Jan 31, 2024
* Add ignoreAnnotatedFunctions to TooManyFunctions * Add TooManyFunctions recommendation to compose docs * Ensure Preview annotation in tests is declared * Simplify hasAnnotation check * Revert "Simplify hasAnnotation check" This reverts commit 3d16e57.
cortinico
pushed a commit
that referenced
this pull request
Jan 31, 2024
* Add ignoreAnnotatedFunctions to TooManyFunctions * Add TooManyFunctions recommendation to compose docs * Ensure Preview annotation in tests is declared * Simplify hasAnnotation check * Revert "Simplify hasAnnotation check" This reverts commit 3d16e57.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #6516