Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency gradle to v8.6 #6939

Merged
merged 1 commit into from Feb 2, 2024
Merged

Update dependency gradle to v8.6 #6939

merged 1 commit into from Feb 2, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 2, 2024

Mend Renovate

This PR contains the following updates:

Package Update Change
gradle (source) minor 8.5 -> 8.6

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

gradle/gradle (gradle)

v8.6

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Feb 2, 2024
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (164618c) 84.71% compared to head (d4ff7f9) 84.71%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6939   +/-   ##
=========================================
  Coverage     84.71%   84.71%           
  Complexity     3935     3935           
=========================================
  Files           579      579           
  Lines         13240    13240           
  Branches       2506     2506           
=========================================
  Hits          11216    11216           
  Misses          773      773           
  Partials       1251     1251           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@3flex 3flex merged commit 6753098 into main Feb 2, 2024
21 checks passed
@3flex 3flex deleted the renovate/gradle-8.x branch February 2, 2024 20:23
@detekt-ci
Copy link
Collaborator

Warnings
⚠️ This PR is approved with no milestone set. If merged, it won't appear in the detekt release notes.

Generated by 🚫 dangerJS against d4ff7f9

@3flex 3flex added this to the 2.0.0 milestone Feb 2, 2024
@cortinico cortinico added notable changes Marker for notable changes in the changelog pick request Marker for PRs that should be ported to the 1.0 release branch labels Feb 3, 2024
@TWiStErRob
Copy link
Member

TWiStErRob commented Feb 6, 2024

@3flex looks like this PR is missing the wrapper update.
See #6939 which has it.

@3flex
Copy link
Member

3flex commented Feb 6, 2024

@TWiStErRob that linked back to this PR?

@cortinico just wondering why this would be a pick request for 1.x or a notable change? Gradle updates should be completely transparent to users.

@cortinico
Copy link
Member

@cortinico just wondering why this would be a pick request for 1.x or a notable change? Gradle updates should be completely transparent to users.

As a rule of thumb, we committed to bring over dependency bumps to 1.x.
Yup this should be completely transparent to users, but also I'd like to make sure the 1.x branch stays up to date and builds against the version of the tools

@TWiStErRob
Copy link
Member

@TWiStErRob that linked back to this PR?

I just double checked the changes here and it wasn't the same. I think there was a Renovate problem. See the warning in OP above. If you run gradlew wrapper on main, there should be changes.

As a rule of thumb, we committed to bring over dependency bumps to 1.x.

@cortinico Should we set up Renovate for the v1 branch? Or you're happy to manually cherry pick everything?

@cortinico
Copy link
Member

@cortinico Should we set up Renovate for the v1 branch? Or you're happy to manually cherry pick everything?

I'm fine manually cherry-picking stuff for now.

@3flex
Copy link
Member

3flex commented Feb 9, 2024

@TWiStErRob #6955. There's only a change to the Windows BAT file after running ./gradlew wrapper (there aren't always changes to the wrapper JAR or startup scripts in new Gradle versions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file notable changes Marker for notable changes in the changelog pick request Marker for PRs that should be ported to the 1.0 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants