Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnusedPrivateClass: don't report if private classes are used for type conversion #6995

Merged
merged 1 commit into from Feb 27, 2024

Conversation

t-kameyama
Copy link
Contributor

Fixes #6982

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 83.78%. Comparing base (a263ecb) to head (5762717).

Files Patch % Lines
...rturbosch/detekt/rules/style/UnusedPrivateClass.kt 50.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6995      +/-   ##
============================================
- Coverage     83.79%   83.78%   -0.02%     
  Complexity     3932     3932              
============================================
  Files           579      579              
  Lines         12100    12104       +4     
  Branches       2506     2508       +2     
============================================
+ Hits          10139    10141       +2     
  Misses          710      710              
- Partials       1251     1253       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BraisGabin
Copy link
Member

Thanks!

@BraisGabin BraisGabin merged commit 70c7586 into detekt:main Feb 27, 2024
20 of 21 checks passed
@detekt-ci
Copy link
Collaborator

Warnings
⚠️ This PR is approved with no milestone set. If merged, it won't appear in the detekt release notes.

Generated by 🚫 dangerJS against 5762717

@BraisGabin BraisGabin added this to the 2.0.0 milestone Feb 27, 2024
@BraisGabin BraisGabin added the pick request Marker for PRs that should be ported to the 1.0 release branch label Feb 27, 2024
@t-kameyama t-kameyama deleted the issue_6982 branch February 27, 2024 08:37
cortinico pushed a commit that referenced this pull request Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pick request Marker for PRs that should be ported to the 1.0 release branch rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnusedPrivateClass Rule does not detect casts as usage
3 participants