Remove unused CliArgs factory
#6997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BraisGabin
force-pushed
the
unused-code-cliargs
branch
from
30ea4ed
to
b1346b3
Compare
BraisGabin
added
breaking change
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6997 +/- ##
=========================================
Coverage 83.85% 83.86%
Complexity 3949 3949
=========================================
Files 578 578
Lines 12155 12154 -1
Branches 2493 2493
=========================================
Hits 10193 10193
+ Misses 733 732 -1
Partials 1229 1229 ☔ View full report in Codecov by Sentry. |
|
So not blocked on #6866 anymore? |
|
No, this is not blocked by that pr anymore. |
cortinico
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is now dead code