Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing overlapping info for NoEmptyClassBody #7031

Closed
wants to merge 1 commit into from

Conversation

tfcporciuncula
Copy link
Contributor

Same thing I did here a while ago, but for some reason got lost at some point: NoEmptyClassBody overlaps with EmptyClassBlock and the docs don't mention it.

@detekt-ci
Copy link
Collaborator

Warnings
⚠️

It looks like you're editing the versioned copy of our website. This affects only users on the 'current' version of detekt, and it's correct only if you intend to fix the documentation for an already released version of detekt. Most of the time you want to update also the docs inside website/docs/ as well, so this change will reflect also for documentation on future versions of detekt.

Messages
📖

Thank you very much for making our website better ❤️!

Generated by 🚫 dangerJS against da99ce8

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.79%. Comparing base (312831b) to head (da99ce8).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7031   +/-   ##
=========================================
  Coverage     83.79%   83.79%           
  Complexity     3941     3941           
=========================================
  Files           579      579           
  Lines         12119    12119           
  Branches       2511     2511           
=========================================
  Hits          10155    10155           
  Misses          710      710           
  Partials       1254     1254           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -387,6 +387,9 @@ See [ktlint docs](https://pinterest.github.io/ktlint/0.50.0/rules/experimental/#

See [ktlint docs](https://pinterest.github.io/ktlint/0.50.0/rules/standard/#no-empty-class-bodies) for documentation.

This rules overlaps with [empty-blocks>EmptyClassBlock](https://detekt.dev/empty-blocks.html#emptyclassblock)
from the standard rules, make sure to enable just one. The pro of this rule is that it can auto-correct the issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The KDoc on the rules needs to be updated so new auto-generated docs include the updates.

Please update the KDoc in the source too so it's fixed more permanently in future versions, thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! New PR here: #7033

@tfcporciuncula
Copy link
Contributor Author

Closing in favor of #7033

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants