New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing overlapping info for NoEmptyClassBody #7031
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7031 +/- ##
=========================================
Coverage 83.79% 83.79%
Complexity 3941 3941
=========================================
Files 579 579
Lines 12119 12119
Branches 2511 2511
=========================================
Hits 10155 10155
Misses 710 710
Partials 1254 1254 ☔ View full report in Codecov by Sentry. |
@@ -387,6 +387,9 @@ See [ktlint docs](https://pinterest.github.io/ktlint/0.50.0/rules/experimental/# | |||
|
|||
See [ktlint docs](https://pinterest.github.io/ktlint/0.50.0/rules/standard/#no-empty-class-bodies) for documentation. | |||
|
|||
This rules overlaps with [empty-blocks>EmptyClassBlock](https://detekt.dev/empty-blocks.html#emptyclassblock) | |||
from the standard rules, make sure to enable just one. The pro of this rule is that it can auto-correct the issue. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The KDoc on the rules needs to be updated so new auto-generated docs include the updates.
Please update the KDoc in the source too so it's fixed more permanently in future versions, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! New PR here: #7033
Closing in favor of #7033 |
Same thing I did here a while ago, but for some reason got lost at some point: NoEmptyClassBody overlaps with EmptyClassBlock and the docs don't mention it.