Allow setting default autocorrect mode with Gradle property #7040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7040 +/- ##
=========================================
Coverage 83.79% 83.79%
Complexity 3941 3941
=========================================
Files 579 579
Lines 12119 12119
Branches 2511 2511
=========================================
Hits 10155 10155
Misses 710 710
Partials 1254 1254 ☔ View full report in Codecov by Sentry. |
This makes it possible to enable autocorrect when running tasks that depend on detekt tasks e.g. ./gradlew check -Pdetekt.default.autocorrect=true Without this, the only way to enable autocorrect on CLI is by declaring every detekt task on the CLI and passing --auto-correct to every one.
3flex
force-pushed
the
autocorrect-property
branch
from
bef771c
to
729f322
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to enable autocorrect when running tasks that depend on detekt tasks e.g.
./gradlew check -Pdetekt.default.autocorrect=trueWithout this, the only way to enable autocorrect on CLI is by declaring every detekt task on the CLI and passing
--auto-correctto every one.Tests will be added once #6913 is merged as that provides some support to pass Gradle properties through to the CLI when setting up tests.