Improve core tests #7232
Merged
Improve core tests #7232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7232 +/- ##
=========================================
Coverage 84.68% 84.69%
Complexity 3984 3984
=========================================
Files 578 578
Lines 12158 12158
Branches 2499 2499
=========================================
+ Hits 10296 10297 +1
Misses 626 626
+ Partials 1236 1235 -1 ☔ View full report in Codecov by Sentry. |
cortinico
approved these changes
Apr 26, 2024
3flex
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR include the 2 first commits of #7101. The idea is that this will simplify the review of that other PR.
In this PR I make that the custom rules that we have for tests on
corereport the correct location of the issue. This is done because later I want to test the suppression and it only works if the location if correct.