Remove ability to create AnalysisResult by passing source code and filename #7255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
detekt-ci
added
rules
api
core
cli
build
formatting
reports
compiler-plugin
parser
labels
3flex
added
the
breaking change
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7255 +/- ##
============================================
+ Coverage 84.74% 84.79% +0.04%
- Complexity 3996 3998 +2
============================================
Files 577 577
Lines 12126 12119 -7
Branches 2484 2483 -1
============================================
Hits 10276 10276
+ Misses 623 616 -7
Partials 1227 1227 ☔ View full report in Codecov by Sentry. |
BraisGabin
approved these changes
May 6, 2024
3flex
added
tooling
and removed
rules
cli
build
formatting
reports
compiler-plugin
labels
…lename Calling detekt from production code should only ever pass a KtFile or a Path (from which a KtFile can be created). Creating KtFile from text directly is only required from tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling detekt from production code should only ever pass a
KtFileor aPath(from which a KtFile can be created).Creating
KtFilefrom text directly is only required from tests.This is a breaking change for detekt-intellij-plugin, but a quick look at the source in that project suggests it will be a simple update.
Waiting on merge of: