Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support native targets #6
Support native targets #6
Changes from 13 commits
11c8543
307e499
e4579a8
786deea
810d4b6
1a314c8
651f772
2548a23
c878ecf
16a80ef
af724ff
be65845
b4ac200
970c770
a36a8d3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this will download about 500MB extra on each CI, and additionally requires 2GB of permanent disk space on local machines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
additionally requires 2GB of permanent disk space on local machines.
I think we have gradle caches so it is not a net new addition if the dev machine already compiles kotlin multiplatform?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's why I noticed it, this is the first KMP build I did.
I don't think
~/.konan
is part of Gradle caches, it seems that Kotlin Native doesn't use the traditional Gradle features to download stuff. Anyway, not much we can do if we want to accept this build feature.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dokka setup looks good.
javadoc-silence.txt
is not necessary although Dokka is quite noisy.This file was deleted.