Add merging utilities #87
Merged
+758
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BraisGabin
approved these changes
Jan 29, 2024
TWiStErRob
reviewed
Jan 29, 2024
TWiStErRob
reviewed
Jan 29, 2024
src/jvmTest/kotlin/io/github/detekt/sarif4k/SarifMergingTest.kt
Outdated
Show resolved
Hide resolved
TWiStErRob
reviewed
Jan 29, 2024
src/jvmTest/kotlin/io/github/detekt/sarif4k/SarifMergingTest.kt
Outdated
Show resolved
Hide resolved
TWiStErRob
reviewed
Jan 29, 2024
src/jvmTest/kotlin/io/github/detekt/sarif4k/SarifMergingTest.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Róbert Papp <papp.robert.s@gmail.com>
this should make it more reliable and ignore whitespace.
TWiStErRob
reviewed
Jan 29, 2024
src/jvmTest/kotlin/io/github/detekt/sarif4k/SarifMergingTest.kt
Outdated
Show resolved
Hide resolved
TWiStErRob
approved these changes
Jan 29, 2024
|
It seems that multiplatform doesn't like |
TWiStErRob
reviewed
Jan 30, 2024
Co-authored-by: Róbert Papp <papp.robert.s@gmail.com>
TWiStErRob
approved these changes
Feb 9, 2024
TWiStErRob
reviewed
Feb 9, 2024
Comment on lines
+32
to
+33
| fun List<Run>.merge(other: List<Run>): List<Run> { | ||
| val runsByTool = (this + other).groupBy { it.tool.driver.fullName } |
There was a problem hiding this comment.
Thanks! Probably, in the future, we will need more tests but these is just a port from detekt so no need to add them in this PR.
@BraisGabin I think this is not just the port of the merger from Detekt, but also extra logic from detekt/detekt#6894, with an extra revision on top of it.
There was a problem hiding this comment.
Yes, but that part I think it have tests. So, to me we can merge and prepare a release. Do you know how to do that?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #82