Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default workflow for Gradle's dependency-submission action #89

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

BraisGabin
Copy link
Member

https://github.com/gradle/actions/blob/v3.0.0/dependency-submission/README.md#general-usage

Also from the README:

The gradle/actions/dependency-submission action provides the simplest (and recommended) way to generate a dependency graph for your project. This action will attempt to detect all dependencies used by your build without building and testing the project itself.

The dependency graph snapshot is generated via integration with the GitHub Dependency Graph Gradle Plugin, and submitted to your repository via the GitHub Dependency Submission API. The generated snapshot files can be submitted in the same job, or saved for submission in a subsequent job.

The generated dependency graph includes all of the dependencies in your build, and is used by GitHub to generate Dependabot Alerts for vulnerable dependencies, as well as to populate the Dependency Graph insights view.

(This is basically a cherry-pick from this PR: detekt/detekt#6933)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@BraisGabin BraisGabin merged commit 3b915e5 into main Feb 2, 2024
@BraisGabin BraisGabin deleted the dependenycy-graph branch February 2, 2024 09:16
@BraisGabin
Copy link
Member Author

It's scary the list of dependencies that this simple project has: https://github.com/detekt/sarif4k/network/dependencies

@TWiStErRob
Copy link
Member

I think for this to be as useful as #90 was, an admin (@BraisGabin @cortinico @chao2zhang?) has to press a button somewhere here:
image

because this page is empty:
https://github.com/detekt/sarif4k/security/dependabot

Compare with detekt.

@BraisGabin
Copy link
Member Author

Done, now it isn't empty.

@TWiStErRob
Copy link
Member

"Great"... thanks.

@BraisGabin
Copy link
Member Author

And now it's empty. I must say that handle this kind of vulnerabilities is a PITA. It's completely different a vulnerability on gradle than a vulnerability that we introduce on the artifact that we release.

@TWiStErRob
Copy link
Member

It doesn't mean we're providing vulnerable code, it means WE (our CI and our local machines) ARE vulnerable. We actually use XML because Gradle parses POM files. There's nothing we can do about this though other than report it to Gradle and keep it up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants