Skip to content

Commit

Permalink
web: get back immediate bootstrapping
Browse files Browse the repository at this point in the history
* as electron/electron#17526 got resolved
  • Loading branch information
devDefiWeb committed Jun 17, 2019
1 parent 29e2740 commit d79d291
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 31 deletions.
35 changes: 16 additions & 19 deletions src/web/src/environments/development/bootstrap-app.ts
Expand Up @@ -8,26 +8,23 @@ import {getZoneNameBoundWebLogger} from "src/web/src/util";

const logger = getZoneNameBoundWebLogger("[environments/development/bootstrap-app]");

// TODO get rid of "onload" handler, see https://github.com/electron/electron/issues/17526
window.addEventListener("load", () => {
bootloader(async () => {
try {
const ngModuleRef = await platformBrowserDynamic().bootstrapModule(AppModule);
const applicationRef = ngModuleRef.injector.get(ApplicationRef);
const componentRef = applicationRef.components[0];
bootloader(async () => {
try {
const ngModuleRef = await platformBrowserDynamic().bootstrapModule(AppModule);
const applicationRef = ngModuleRef.injector.get(ApplicationRef);
const componentRef = applicationRef.components[0];

enableDebugTools(componentRef);
enableDebugTools(componentRef);

if (!module.hot) {
throw new Error("webpack-dev-server: HMR is not enabled");
}

return hmrModule(ngModuleRef, module);
} catch (error) {
// tslint:disable-next-line:no-console
console.error(error);
logger.error(error);
throw error;
if (!module.hot) {
throw new Error("webpack-dev-server: HMR is not enabled");
}
});

return hmrModule(ngModuleRef, module);
} catch (error) {
// tslint:disable-next-line:no-console
console.error(error);
logger.error(error);
throw error;
}
});
21 changes: 9 additions & 12 deletions src/web/src/environments/production/bootstrap-app.ts
Expand Up @@ -6,16 +6,13 @@ import {getZoneNameBoundWebLogger} from "src/web/src/util";

const logger = getZoneNameBoundWebLogger("[environments/production/bootstrap-app]");

// TODO get rid of "onload" handler, see https://github.com/electron/electron/issues/17526
window.addEventListener("load", () => {
enableProdMode();
enableProdMode();

platformBrowserDynamic()
.bootstrapModule(AppModule)
.catch((error) => {
// tslint:disable-next-line:no-console
console.error(error);
logger.error(error);
throw error;
});
});
platformBrowserDynamic()
.bootstrapModule(AppModule)
.catch((error) => {
// tslint:disable-next-line:no-console
console.error(error);
logger.error(error);
throw error;
});

0 comments on commit d79d291

Please sign in to comment.