Add ruff to DEFAULT_UTILS in python #546
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruff is currently one of the fastest growing tools in terms of adaption in the Python community. Many large projects have adopted it.
samruddhikhandale
requested changes
May 9, 2023
| @@ -26,7 +26,7 @@ CONFIGURE_JUPYTERLAB_ALLOW_ORIGIN="${CONFIGUREJUPYTERLABALLOWORIGIN:-""}" | |||
| # alongside PYTHON_VERSION, but not set as default. | |||
| ADDITIONAL_VERSIONS="${ADDITIONALVERSIONS:-""}" | |||
|
|
|||
| DEFAULT_UTILS=("pylint" "flake8" "autopep8" "black" "yapf" "mypy" "pydocstyle" "pycodestyle" "bandit" "pipenv" "virtualenv" "pytest") | |||
| DEFAULT_UTILS=("pylint" "flake8" "autopep8" "black" "yapf" "mypy" "pydocstyle" "pycodestyle" "bandit" "pipenv" "virtualenv" "pytest" "ruff") | |||
There was a problem hiding this comment.
Can we bump the minor version as we are adding this new util? thanks!
There was a problem hiding this comment.
Can you help add similar tests/checks for ruff?
There was a problem hiding this comment.
My apologies for the delay. I have both added the check and which tests and bumped the minor version.
|
@microsoft-github-policy-service agree |
|
@samruddhikhandale, I believe I have addressed all suggestions. Can we get this merged? 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruff is currently one of the fastest growing tools in terms of adaption in the Python community. Many large projects have adopted it.
For example, it has many more stars than many of the other projects listed here.