Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chmod+x to all .sh files #561

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

AceHack
Copy link

@AceHack AceHack commented May 25, 2023

I call this from Ubuntu, and I need them to already have the chmod +x attribute applied.

@AceHack AceHack requested a review from a team as a code owner May 25, 2023 23:22
@AceHack
Copy link
Author

AceHack commented May 31, 2023

Can anyone approve this?

@joshspicer
Copy link
Member

Thanks for taking time to contribute!

The dev container tooling will ensure that the execute bit is always set before running these scripts. While these Feature scripts may mostly work if executed directly, it is not recommended to do so as they are designed specifically to work with the dev container CLI (or another supporting tool) and are subject to future changes diverging it from a 'simple shell script'. For example, Specs like this one, if implemented, will require the orchestrating CLI to source the requisite library scripts first.

May I ask what your use case is for running these scripts directly outside the tooling? That may help me understand a gap in said tooling that we can improve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants