-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use \$
as the final character of PS1
#594
base: main
Are you sure you want to change the base?
Conversation
would you mind sharing some screenshots of both the bug you're fixing with this and the result of the change? |
I updated the PR description, please check it. Thank you. |
@@ -18,7 +18,7 @@ __bash_prompt() { | |||
fi`' | |||
local lightblue='\[\033[1;34m\]' | |||
local removecolor='\[\033[0m\]' | |||
PS1="${userpart} ${lightblue}\w ${gitbranch}${removecolor}\$ " | |||
PS1="${userpart} ${lightblue}\w ${gitbranch}${removecolor}\\$ " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! However, @Chuxel double checking if this wasn't intentional.
@@ -18,7 +18,7 @@ __bash_prompt() { | |||
fi`' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we bump the patch version in here, thanks!
"version": "2.0.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we bump the patch version in here, thanks!
@samruddhikhandale thank you for the comment.
Do you mean I should bump the patch version on this PR?
Or should we wait for this to be merged, and then bump the patch in another PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the commit. Please let me know if something is wrong.
@casaroli please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
@microsoft-github-policy-service agree |
If the effective UID is
0
, display#
, otherwise, display$
in the end ofPS1
Since we use double quotes
"
, we should use\\
.I believe this was the intended behavior.
Current:
With the change applied: