Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker-buildx-plugin for non-moby installation. #685

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rurabori
Copy link

@rurabori rurabori commented Sep 9, 2023

When setup as :

"ghcr.io/devcontainers/features/docker-in-docker:2": {
			"version": "latest",
			"moby": false,
			"dockerDashComposeVersion": "v2",
			"installDockerBuildx": true
		},

Docker complains about missing buildx, adding the plugin install fixes the issue.

@rurabori rurabori requested a review from a team as a code owner September 9, 2023 16:05
@rurabori
Copy link
Author

rurabori commented Sep 9, 2023

@rurabori please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the value for installDockerBuildx option, https://github.com/devcontainers/features/blob/main/src/docker-in-docker/install.sh#L331-L346 should install docker buildx.

The below config works fine for me 👇

{
	"image": "mcr.microsoft.com/devcontainers/base:jammy",
	"features": {
		"ghcr.io/devcontainers/features/docker-in-docker:2": {
			"version": "latest",
			"moby": false,
			"dockerDashComposeVersion": "v2",
			"installDockerBuildx": true
		}
	}
}

image

@rurabori Is this not working for you? If not, I wonder if you are facing the issue reported in devcontainers/cli#331. If that's the case, do you mind commenting on that issue? Thanks!

@jon-git-king
Copy link

@rurabori please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants