-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Apple ARM - NVIDIA CUDA] Skip install #730
base: main
Are you sure you want to change the base?
Conversation
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the prompt PR creation, left some clarifying questions.
@@ -17,6 +17,11 @@ if [ "$(id -u)" -ne 0 ]; then | |||
exit 1 | |||
fi | |||
|
|||
if [[ $(uname -m) = "aarch64" ]]; then | |||
echo -e "NVIDIA® CUDA Toolkit no longer supports development or running applications on machines with the 'arm64' architecture. Please consider an alternative or check for updates or support for your architecture." | |||
exit 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't https://developer.nvidia.com/nvidia-cuda-toolkit-11_7_0-developer-tools-mac-hosts refer to NVIDIA toolkit no longer supporting MacOS?
Hence, instead of failing the entire Feature, why don't we update 👇 instead?
features/src/nvidia-cuda/install.sh
Lines 95 to 98 in 9f152b5
if [ "$INSTALL_TOOLKIT" = "true" ]; then | |
echo "Installing CUDA Toolkit..." | |
apt-get install -yq "$toolkit_pkg" | |
fi |
@@ -17,6 +17,11 @@ if [ "$(id -u)" -ne 0 ]; then | |||
exit 1 | |||
fi | |||
|
|||
if [[ $(uname -m) = "aarch64" ]]; then | |||
echo -e "NVIDIA® CUDA Toolkit no longer supports development or running applications on machines with the 'arm64' architecture. Please consider an alternative or check for updates or support for your architecture." | |||
exit 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that, I have other developers on my repository who are using containers with a classic chip architecture, and it's essential for me to retain this feature for them.
My primary question is: How can I add a condition to specify the architecture and install or not the feature?
From the discussion, note that if the Feature returns exit code 1
, then your dev container creation will fail. Unless, you switch the Feature option installToolkit
to false
.
Skip installation for ARM chip because Nvdia Cuda Toolkit is no longer supported.
Reference: https://developer.nvidia.com/nvidia-cuda-toolkit-11_7_0-developer-tools-mac-hosts
PR related to this discussion : https://github.com/orgs/devcontainers/discussions/78#discussioncomment-7343974