Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] add default formatter #903

Merged
merged 2 commits into from
May 28, 2024

Conversation

hellodword
Copy link
Contributor

No description provided.

@hellodword hellodword requested a review from a team as a code owner March 10, 2024 08:02
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@hoechenberger
Copy link
Contributor

Why would you want to use this instead of the Ruff extension?

Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we missed merging this, approving again ⚡

@samruddhikhandale samruddhikhandale enabled auto-merge (squash) May 28, 2024 23:03
@samruddhikhandale samruddhikhandale merged commit 02b71cb into devcontainers:main May 28, 2024
11 of 12 checks passed
@pickfire
Copy link

This broke ruff installation that I had to remove this feature altogether, can this be added behind a feature gate disabled by default? Given that there are quite a few well known alternative, I don't think autopep8 should be enabled by default.

@hoechenberger
Copy link
Contributor

hoechenberger commented Jun 12, 2024

@pickfire I added “-ms-python.autopep8“ to the extensions sections of my dev container config (mind the minus sign, which will remove the extension). And I added a formatter entry to use ruff.

I have to agree that this PR made life harder. Not a fan.

@hellodword hellodword deleted the patch-1 branch June 12, 2024 04:27
@hellodword
Copy link
Contributor Author

@pickfire @hoechenberger Sorry dudes, I sadly didn't consider about that, maybe a revert is required @samruddhikhandale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants