Fixed infinite refresh issue caused by Websocket (Vite) failing to connect using Gitpod #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
praise: Beautiful work! Thanks for the fix. suggestion: Can you add an update to the README with some images to instruct people how to swap localhost with the gitpod url? Once we get the README updated, we can go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outdated Vite dependency caused Websocket to constantly refresh the page once failing to connect. Specifying clientport instead of port resolves the issue. I also used the code below to make it so that vite config automatically changes based on whether you're using localhost or Gitpod's workspace. However you still need to specifiy the database URL depending on which one you're using (possible future enhancement?)
Reference
HMR Broken
Client Port Fix