Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript documentation #40

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

screendriver
Copy link

Related to issue #3

rules: [
{
test: /\.worker\.ts$/,
use: ['workerize-loader', 'ts-loader'],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this correct? ts-loader should already be getting applied via line 59.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this solutions not work for me

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this correct? ts-loader should already be getting applied via line 59.

I'm guessing that the purpose here is to ensure that .worker.ts are chained through ts-loader and then workerize-loader?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest I can't remember. It's over one year ago when I opened that pull request 😅 The only thing I can remember is that I had some issues and I copy and pasted my solution into this pull request and it worked.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the solution in your pr work for you? I'm thinking of taking it for a spin (I happened upon this in the first place as I'm planning to use web workers with TypeScript and webpack)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last time when I played around with that was 1 year ago. So I don't know if it still works 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants