Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: kubeflow (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #2117

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

weh
Copy link
Contributor

@weh weh commented Jan 18, 2024

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

**This PR closes #2086 **

Link to prove your SVG is correct and up-to-date.

@weh weh requested review from a team, ConX, Snailedlt, canaleal and lunatic-fox and removed request for a team January 18, 2024 13:29
Copy link
Contributor

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you for the contribution! 😄

The json looks excellent, but the SVGs need a few modifications.

The viewboxes for all SVGs are not 0 0 128 128 and the plain-wordmark svg has strokes that should be converted into a unified path.

@weh
Copy link
Contributor Author

weh commented Jan 22, 2024

sorry @canaleal, looks like i committed the unfinished files. should be fixed now.

Copy link
Contributor

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

I left a few comments about the padding/alignment on some of the SVGs, but aside from that everything else looks excellent.

icons/kubeflow/kubeflow-line-wordmark.svg Show resolved Hide resolved
icons/kubeflow/kubeflow-plain-wordmark.svg Show resolved Hide resolved
icons/kubeflow/kubeflow-line.svg Show resolved Hide resolved
@weh
Copy link
Contributor Author

weh commented Jan 31, 2024

@canaleal i fixed the image box issues. hope this time i got it right 🤞

@weh weh requested a review from canaleal February 7, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants