Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: StencilJS (original, original-wordmark) #2157

Merged
merged 10 commits into from May 25, 2024

Conversation

gitChaoslord
Copy link

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

This PR closes #866

Link to prove your SVG is correct and up-to-date.

The SVGs can be found here by downloading the "full press kit" at the bottom of page.

I've manipulated the downloaded SVGs using the following tools

Copy link
Contributor

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @gitChaoslord, great job! 👍

Just a couple of things to note:

  1. The names "stencil-original colored" and "wordmark colored" aren't valid SVG versions. Check the wiki for a list of valid names.
  2. Make sure the SVGs adhere to the SVG Standards.

It seems the official logo is the black version, so use that as the basis for "original" and "original-wordmark.svg".

@gitChaoslord
Copy link
Author

Hello @canaleal, thank you!

I've made some adjustments based on your input.

  • Removed the "colored" word from the icon names
  • I've decided to name the "black" logo as plain and the "white" as original, ( My reason was the white also had an opacity attribute on one element )
  • Made sure the contents are centered
  • Removed all padding on the X axis ( Y axis has some padding left to prevent distortion )

Copy link
Contributor

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work 👍 Everything is almost ready.

Just 2 more changes:

The plain and plain-wordmark svgs need to have only 1 path. You can use the unify feature in inkscape to do this.

Great work using SVGOMG! For the final step, do the same but turn on all the feature options except:

  • Remove xmlns
  • Round/rewrite number lists
  • Replace duplicate elements with lists

After optimizing, ensure that the svg code is one line long and includes a single empty line at the end.

devicon.json Outdated Show resolved Hide resolved
devicon.json Show resolved Hide resolved
@gitChaoslord
Copy link
Author

gitChaoslord commented Mar 3, 2024

Hello again @canaleal

I've performed the requested changes as per your instructions

  • Corrected the color in devicons.json
  • Removed original & original-wordmark from the font version
  • Unified the plain & plain-workmark paths into a single one
  • Formatted file contents to be in the first line and added a second empty line

Let me know if there is anything else missing

Copy link
Contributor

github-actions bot commented Mar 3, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60



Error found regarding filenames:
- This path doesn't exist: '/home/runner/work/devicon/devicon/icons/stenciljs/stenciljs-original-wordmark.svg'

Error checking SVGs: no SVGs to check. Might be caused by above issues.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

canaleal
canaleal previously approved these changes Mar 3, 2024
Copy link
Contributor

github-actions bot commented Mar 3, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

Copy link
Contributor

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect work!🚀

Made 2 changes:

  • Updated file name workmark to wordmark on the original svg.
  • Removed the fill="none" from all SVGs.

Looks good on icomoon:
image

Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nothing to add here :)

Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal merged commit f812c16 into devicons:develop May 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants