Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: pug (original, plain) #2174

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

GCHQDeveloper926
Copy link

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

**This PR closes #567 **

Link to prove your SVG is correct and up-to-date.

(https://github.com/pugjs/pug-logo/blob/master/SVG/pug-final-logo-_-colour-128.svg)

@GCHQDeveloper926 GCHQDeveloper926 changed the base branch from master to develop March 28, 2024 13:59
@GCHQDeveloper926
Copy link
Author

GCHQDeveloper926 commented Mar 28, 2024

First PR into here but hopefully have met all the required points.
Do I need to remove the title/formatting from original SVG that I've copied?

devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, the SVG is 128x128 but it has to be centered vertically/horizontally and optimized.

You can follow this tutorial on how to do it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not gonna lie, this icon will be hard to convert into a plain svg.
Right now, all plain svgs should only have 1 path and 1 fill color as mentioned in the wiki. This svg has multiple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon request: Pug
2 participants