New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: cloudrun (original, plain, line) #2186
base: develop
Are you sure you want to change the base?
Conversation
icons/cloudrun/cloudrun-original.svg
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original, plain, and line svgs do not fill the viewbox and are not centered horizontally or vertically. The svgs also have to be optimized.
Here's a tutorial on how to fix these problems using inkscape.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the tutorial, this is will be helpful!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. We just need to make the sure that the SVGs are optimized and that the plain and line svgs only have 1 path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work scaling the SVG! Now let's ungroup the paths and optimize the SVG using SVGOMG as described near the bottom of the tutorial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this SVG the paths have to be unified into a single path and optimized just like the original.svg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this SVG the paths have to be unified into a single path and optimized just like the original.svg.
Double check these details before you open a PR
develop
branch.devicon.json
file at the correct alphabetic position as seen here**This PR closes #2180 **
Link to prove your SVG is correct and up-to-date.
Google Tutorial on Cloudrun with icon displayed