Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: cloudrun (original, plain, line) #2186

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

this-is-emma
Copy link

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

**This PR closes #2180 **

Link to prove your SVG is correct and up-to-date.

Google Tutorial on Cloudrun with icon displayed

devicon.json Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original, plain, and line svgs do not fill the viewbox and are not centered horizontally or vertically. The svgs also have to be optimized.

image

Here's a tutorial on how to fix these problems using inkscape.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tutorial, this is will be helpful!

@canaleal canaleal changed the title new icon: Cloudrun new icon: cloudrun (original, plain, line) Apr 24, 2024
@canaleal canaleal added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Apr 24, 2024
Copy link
Contributor

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. We just need to make the sure that the SVGs are optimized and that the plain and line svgs only have 1 path.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work scaling the SVG! Now let's ungroup the paths and optimize the SVG using SVGOMG as described near the bottom of the tutorial.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this SVG the paths have to be unified into a single path and optimized just like the original.svg

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this SVG the paths have to be unified into a single path and optimized just like the original.svg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants