Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding export option to excel (.xlsx) #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Zvikan
Copy link

@Zvikan Zvikan commented Mar 11, 2020

As #21 is still on not completed, I took it into my hands and completed some parts of it.

  • Downloading as an excel (.xlsx) and not TSV/VSC file
  • Export per resource per region like feature: download tsv data from each inventoried resource #21
  • Added export select-box at the bottom of the regions list panel
  • Export by region (export everything in that region)
  • Export everything (all regions)
  • Empty tables(no resources under that region) will not be exported to avoid empty sheets

Notes:
Exporting everything right now will download multiple files, excel files per region.
The reasons I did it are:

  • Excel sheet limited to 32 charts so can't have something like "us-west-2-cloudformation-x-y-z-a-b-c" and this required too much of substring or shorting the resource name which might create confusion to the user
  • Single excel with all the available resources of all regions will have too many sheets and it will be tooooooooo long.. the user will get lost there, even if using the excel's "jump to a sheet by name option"

@kesor I am not sure if I am completely happy with the select-box position right now, let me know what do you think I can move it around or add some extra padding to prettier it

@Zvikan Zvikan changed the title adding export to excel options Adding export option to excel (.xlsx) Mar 11, 2020
@Zvikan
Copy link
Author

Zvikan commented Mar 11, 2020

Added some top padding in the export div so it will have some spacing between the region navigation list to the export button line.

@kesor kesor added this to In progress in Planning Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Planning
  
In progress
Development

Successfully merging this pull request may close these issues.

None yet

1 participant