Enh add snapshot feature WIP #900
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 20, 2022 11:27
…ature # Conflicts: # server/devpi_server/model.py
|
@fschulze wdyt of this ? |
added 13 commits
June 21, 2022 07:31
+ accumulate and return failures of particular project-version.
fschulze
requested changes
Jun 23, 2022
server/devpi_server/main.py
Outdated
| @@ -462,6 +462,10 @@ def create_app(self): | |||
| pyramid_config.add_view_deriver(self.view_deriver, under=INGRESS) | |||
| pyramid_config.add_view_predicate('content_type', ContentTypePredicate) | |||
|
|
|||
| # snapshoting | |||
| pyramid_config.add_route("/+snapshot/{user}/{index}", "/+snapshot/{user}/{index}") | |||
There was a problem hiding this comment.
I would prefer the COPY HTTP method, if you have good arguments against that, then I would like /{user}/{index}/+copy. Snapshotting should be an option selected with ?snapshot.
|
As a summary:
I'm undecided whether we should allow this for mirror indexes. I currently lean towards forbidding it. |
gst
force-pushed
the
enh-add-snapshot-feature
branch
from
55f3acf
to
4f42341
Compare
|
FYI, I rebased and squashed your branch at https://github.com/fschulze/devpi/tree/enh-add-snapshot-feature. I cherry picked some changes like the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would solve #897