Made code pass ansible-lint v5 checks #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@greg-hellings Take a look, please. |
I use a git submodule for configuring ansible-lint changes, it's located in tests/. I've taken the liberty of updating the ansible-lint config file there with the no-handler option (the yaml line is already in there).
greg-hellings
approved these changes
Mar 7, 2021
.ansible-lint
Outdated
| skip_list: | ||
| # temporary added during migration to v5 | ||
| - yaml | ||
| - no-handler |
There was a problem hiding this comment.
I use a git submodule for configuring ansible-lint changes, it's located in tests/ if you git submodule init && git submodule update. I've taken the liberty of updating the ansible-lint config file there with the no-handler option (the yaml check is already in there).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: ansible/ansible-lint#1434