resolve require section from imports #2624
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>
if possible)This PR adds a special handling of the
require
section inloader.ResolveImports
. Instead of overwriting command and plugin constraints, it appends them to the existing ones. This was not handled correctly before, as imported "libraries" overwrote the existing constraints.It also changes the handling of constraints for
devspace
versios by adding the version constraints form imported files to a already existing constraint, separated by comma.Example:
>=6.0, >=6.1
Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace did not resolve command and plugin constraints from imports
What else do we need to know?