Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:wire nil test in pre ci pipeline #4858

Merged
merged 133 commits into from
May 21, 2024
Merged

feat:wire nil test in pre ci pipeline #4858

merged 133 commits into from
May 21, 2024

Conversation

Laeeqdev
Copy link
Contributor

@Laeeqdev Laeeqdev commented Apr 1, 2024

Description

Created the 'wireNilCheck' function to identify nil fields within data. Scripts were devised to run this function within a Docker container, facilitating its integration into our Continuous Integration (CI) pipeline without port forwarding. This allows us to validate data integrity early in the process, ensuring that any nil fields are caught and handled appropriately to prevent pipeline failure during pre-CI checks.
Fixes #5144

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Copy link

gitguardian bot commented Apr 5, 2024

⚠️ GitGuardian has uncovered 10 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10190659 Triggered Generic High Entropy Secret 910d88f wireNil.env View secret
10190659 Triggered Generic High Entropy Secret 1102b85 wireNil.env View secret
10190659 Triggered Generic High Entropy Secret 04dafc1 wireNil.env View secret
10190659 Triggered Generic High Entropy Secret 1df34c6 wireNil.env View secret
10190660 Triggered Generic Password 910d88f tests/integrationTesting/devtron-secret.yaml View secret
10190660 Triggered Generic Password 04dafc1 tests/integrationTesting/devtron-secret.yaml View secret
10190661 Triggered Generic Password 910d88f wireNil.env View secret
10190661 Triggered Generic Password 04dafc1 wireNil.env View secret
10220829 Triggered Generic High Entropy Secret 92fe5b4 charts/devtron/values.yaml View secret
10220829 Triggered Generic High Entropy Secret 92fe5b4 charts/devtron/devtron-bom.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

# #
#################################

- name: reloader

Check warning

Code scanning / SonarCloud

Memory limits should be enforced Medium

Specify a memory limit for this container. See more on SonarCloud
# #
##############################

- name: metrics

Check warning

Code scanning / SonarCloud

Memory limits should be enforced Medium

Specify a memory limit for this container. See more on SonarCloud
tests/integrationTesting/nats-server.yaml Fixed Show fixed Hide fixed

app.kubernetes.io/name: nats
app.kubernetes.io/instance: devtron-nats
spec:

Check warning

Code scanning / SonarCloud

Service account tokens should not be mounted in pods Medium

Set automountServiceAccountToken to false for this specification of kind StatefulSet. See more on SonarCloud
tests/integrationTesting/nats-server.yaml Fixed Show fixed Hide fixed
#################
terminationGracePeriodSeconds: 120
containers:
- name: nats

Check warning

Code scanning / SonarCloud

CPU limits should be enforced Medium

Specify a CPU limit for this container. See more on SonarCloud
# #
#################################

- name: reloader

Check warning

Code scanning / SonarCloud

CPU limits should be enforced Medium

Specify a CPU limit for this container. See more on SonarCloud
# #
##############################

- name: metrics

Check warning

Code scanning / SonarCloud

CPU limits should be enforced Medium

Specify a CPU limit for this container. See more on SonarCloud
tests/integrationTesting/nats-server.yaml Fixed Show fixed Hide fixed
#################
terminationGracePeriodSeconds: 120
containers:
- name: nats

Check warning

Code scanning / SonarCloud

Memory limits should be enforced Medium

Specify a memory limit for this container. See more on SonarCloud
@Laeeqdev Laeeqdev changed the title feat:wire nil test in pre ci pipeline fea:wire nil test in pre ci pipeline May 21, 2024
@Laeeqdev Laeeqdev changed the title fea:wire nil test in pre ci pipeline feat:wire nil test in pre ci pipeline May 21, 2024
Copy link

PR is not linked to any issue, please make the corresponding changes in the body.

Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@Laeeqdev Laeeqdev merged commit 93fbeae into main May 21, 2024
7 of 9 checks passed
@Laeeqdev Laeeqdev deleted the run-time-main-and-binary branch May 21, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature:wire nil test in pre ci pipeline
3 participants