Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Material-info-overview git details #4869

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

RajeevRanjan27
Copy link
Contributor

@RajeevRanjan27 RajeevRanjan27 commented Apr 2, 2024

Description

Fixes #4638
Fixes #4401

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Copy link

gitguardian bot commented Apr 2, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9404168 Triggered Username Password 735bdea internal/util/ArgoUtil/ArgoClient.go View secret
10220829 Triggered Generic High Entropy Secret f8e454c charts/devtron/values.yaml View secret
10220829 Triggered Generic High Entropy Secret f8e454c charts/devtron/devtron-bom.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

github-actions bot commented Apr 2, 2024

PR is not linked to any issue, please make the corresponding changes in the body.

pkg/pipeline/CiHandler.go Outdated Show resolved Hide resolved
pkg/pipeline/CiHandler.go Outdated Show resolved Hide resolved
@RajeevRanjan27 RajeevRanjan27 changed the title fix: deploy detail info missing for copy container image artifact and different datasource fix: material-info-overview Apr 8, 2024
@RajeevRanjan27 RajeevRanjan27 changed the title fix: material-info-overview fix: Material-info-overview git details Apr 8, 2024
Copy link

sonarcloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants